-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754 #3058
Conversation
Reviewed-by: xuelei, mbaesken
…ails with RuntimeException Server not ready Reviewed-by: jnimeh
…ncorrect comment information Reviewed-by: jnimeh, fyang
…lp diagnose JDK-8309754 Reviewed-by: mullan
👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into |
@alexeybakhtin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi |
The parent pull request that this pull request depends on has been closed without being integrated and the target branch of this pull request has been updated as the previous branch was deleted. This means that changes from the parent pull request will start to show up in this pull request. If closing the parent pull request was done in error, it will need to be re-opened and this pull request will need to manually be retargeted again. |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8337826
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@alexeybakhtin this pull request can not be integrated into git checkout JDK-8337826
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
/integrate |
Going to push as commit 9db8d285c0dba15d3dff0af27ae0990c2dc1458e. |
@alexeybakhtin Pushed as commit 9db8d28. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Follow-up clean test backport for JDK-8179502 (fourth in the series, applied after 8325024)
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3058/head:pull/3058
$ git checkout pull/3058
Update a local copy of the PR:
$ git checkout pull/3058
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3058/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3058
View PR using the GUI difftool:
$ git pr show -t 3058
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3058.diff
Using Webrev
Link to Webrev Comment