Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754 #3058

Closed
wants to merge 8 commits into from

Conversation

alexeybakhtin
Copy link

@alexeybakhtin alexeybakhtin commented Nov 18, 2024

Follow-up clean test backport for JDK-8179502 (fourth in the series, applied after 8325024)


Progress

  • Change must not contain extraneous whitespace
  • JDK-8337826 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754 (Enhancement - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3058/head:pull/3058
$ git checkout pull/3058

Update a local copy of the PR:
$ git checkout pull/3058
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3058/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3058

View PR using the GUI difftool:
$ git pr show -t 3058

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3058.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2024

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into pr/3057 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

@alexeybakhtin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 9b11bd7f4a511ddadf9f02e82aab6ba78beb6763 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754 Nov 18, 2024
@openjdk
Copy link

openjdk bot commented Nov 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Nov 18, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2024

Webrevs

@openjdk openjdk bot added approval and removed approval labels Nov 18, 2024
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 20, 2024
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2024

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@GoeLin
Copy link
Member

GoeLin commented Jan 10, 2025

Hi
you might want to label fix-request on this again. Thanks for bringing it to 21.

@openjdk openjdk bot added approval and removed approval labels Jan 10, 2025
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/3057 to pr/3056 January 14, 2025 15:49
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has been closed without being integrated and the target branch of this pull request has been updated as the previous branch was deleted. This means that changes from the parent pull request will start to show up in this pull request. If closing the parent pull request was done in error, it will need to be re-opened and this pull request will need to manually be retargeted again.

@openjdk openjdk bot removed the clean label Jan 14, 2025
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/3056 to master January 17, 2025 19:41
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8337826
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Jan 17, 2025

@alexeybakhtin this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8337826
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Jan 17, 2025
@openjdk openjdk bot added clean ready Pull request is ready to be integrated and removed merge-conflict Pull request has merge conflict with target branch labels Jan 17, 2025
@alexeybakhtin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 17, 2025

Going to push as commit 9db8d285c0dba15d3dff0af27ae0990c2dc1458e.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 17, 2025
@openjdk openjdk bot closed this Jan 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 17, 2025
@openjdk
Copy link

openjdk bot commented Jan 17, 2025

@alexeybakhtin Pushed as commit 9db8d28.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants